Skip to content

POTEL 13 - Use transaction name #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Jun 18, 2024
Merged

POTEL 13 - Use transaction name #3464

merged 68 commits into from
Jun 18, 2024

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jun 6, 2024

This was temporarily broken in a previous PR

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
@adinauer
replace hub with scopes
305baf5
@adinauer
Add Scopes
95f5e1b
@adinauer
Introduce IScopes interface.
27f2398
@adinauer
Replace IHub with IScopes in core
ce3c14f
@adinauer
Replace IHub with IScopes in android core
ce615f4
@adinauer
Replace IHub with IScopes in android integrations
22ddc00
@adinauer
Replace IHub with IScopes in apollo integrations
305c217
@adinauer
Replace IHub with IScopes in okhttp integration
da927bc
@adinauer
Replace IHub with IScopes in graphql integration
8279276
@adinauer
Replace IHub with IScopes in logging integrations
9bfc086
@adinauer
Replace IHub with IScopes in more integrations
b998e50
@adinauer
Replace IHub with IScopes in OTel integration
739827a
@adinauer
Replace IHub with IScopes in Spring 5 / Spring Boot 2 integrations
69f2d63
@adinauer
Replace IHub with IScopes in Spring 6 / Spring Boot 3 integrations
792d482
@adinauer
Replace IHub with IScopes in samples
9bcbce6
@adinauer
Merge branch 'feat/hsm-13-replacements-in-samples' into feat/hubs-sco…
3f25a4b 
…pes-merge-2-add-scopes
@adinauer
gitscopes -> github
d6fb40a
@adinauer
Replace ThreadLocal with ScopesStorage
7752bcc
@adinauer
Move client and throwable to span map to scope
1e329c5
@adinauer
Add global scope
b0d89ae
@adinauer
use global scope in Scopes
cdd414a
@adinauer
Implement pushScope popScope and withScope for Scopes
98da9ff
@adinauer
Add pushIsolationScope; add fork methods to ISCope
2d26033
@adinauer
Use separate scopes for current, isolation and global scope; rename m…
bbb6700 
…ainScopes to rootScopes
@adinauer
Allow controlling which scope configureScope uses
c714b21
@adinauer
Combine scopes
a474402
@adinauer
Use new API for CRONS integrations
ae93e33
@adinauer
Add lifecycle helper
b01298b
@adinauer
Change spring integrations to use new API
b64e688
@adinauer
Use new API in servlet integrations
d06fc50
adinauer and others added 17 commits April 30, 2024 10:38
@adinauer
Use OpenTelemetry for Performance and Scopes propagation
37ab4d0
@adinauer
Promote certain span attributes
faef2f8
@adinauer
Merge branch '8.x.x' into feat/potel-1-context-forking-and-basics
c57b2d3
@adinauer
Merge branch '8.x.x' into feat/potel-1-context-forking-and-basics
5b15128
@adinauer
Merge branch 'feat/potel-1-context-forking-and-basics' into feat/pote…
9d48538 
…l-2-promote-span-attributes
@adinauer
Use OTel in Sentry API
9b900c7
@adinauer
Deduplicate SpanInfo extraction
b3919bd
@adinauer
Forward Sentry API to Sentry through OTel
36ed84a
@adinauer
Use OTel status for Sentry span API
8f56e3f
@adinauer
POTel Tracing
81982bc
@adinauer
fix root span detection (remote flag), and scope closing
fba451c
@adinauer
Inherit OTel span IDs when sending to sentry
c787e91
@adinauer
Fix tracing; parse incoming baggage; add baggage to outgoing
8c25d81
@adinauer
Cleanup
ffe1bef
@adinauer
Move sampling logic to OTel Sampler
a31fc08
@adinauer
Remove internal span attributes so they are not sent to Sentry
789ae1e
@adinauer
Use transaction name
f0c8cf2
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 13 - Use transaction name ([#3464](https://github.com/getsentry/sentry-java/pull/3464))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 46a48b4

adinauer
adinauer commented Jun 6, 2024
View reviewed changes
...ry/sentry-opentelemetry-bootstrap/src/main/java/io/sentry/opentelemetry/OtelSpanFactory.java
}
if (samplingDecision != null) {
sentrySpan.getSpanContext().setSamplingDecision(samplingDecision);
// TODO [POTEL] do we need this?
Copy link
Member Author

@adinauer adinauer Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting sampling decision should no longer be necessary since we already attach it as separate attributes above

@adinauer adinauer changed the title POTEL 12 - Use transaction name POTEL 13 - Use transaction name Jun 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 358.02 ms 439.24 ms 81.22 ms
Size 1.70 MiB 2.28 MiB 596.06 KiB

Baseline results on branch: feat/potel-12-remove-internal-attributes

Startup times

Revision Plain With Sentry Diff
de2f57a 591.17 ms 724.76 ms 133.59 ms

App size

Revision Plain With Sentry Diff
de2f57a 1.70 MiB 2.28 MiB 596.06 KiB

lbloder
lbloder approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/potel-12-remove-internal-attributes to 8.x.x June 18, 2024 05:51
@adinauer adinauer merged commit 94ba63c into 8.x.x Jun 18, 2024
@adinauer adinauer deleted the feat/potel-13-use-transaction-name branch June 18, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @lbloder