Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer and others added 30 commits March 27, 2024 16:30
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a641526

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 496.44 ms 564.23 ms 67.79 ms
Size 1.70 MiB 2.28 MiB 595.91 KiB

Previous results on branch: feat/hsm-25-servlet-integrations

Startup times

Revision Plain With Sentry Diff
91064ff 356.33 ms 439.16 ms 82.83 ms

App size

Revision Plain With Sentry Diff
91064ff 1.70 MiB 2.28 MiB 595.91 KiB

@Open
public class SentryServletRequestListener implements ServletRequestListener {

public static final String SENTRY_LIFECYCLE_TOKEN_KEY = "sentry-lifecycle";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How about making it more clear this key takes care of the scope lifecycle?

Suggested change
public static final String SENTRY_LIFECYCLE_TOKEN_KEY = "sentry-lifecycle";
public static final String SENTRY_SCOPE_LIFECYCLE_TOKEN_KEY = "sentry-scope-lifecycle";

Base automatically changed from feat/hsm-24-spring-integrations to 8.x.x April 22, 2024 13:25
@adinauer adinauer merged commit 153f678 into 8.x.x Apr 22, 2024
@adinauer adinauer deleted the feat/hsm-25-servlet-integrations branch April 22, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants