Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Apr 2, 2024

#skip-changelog

📜 Description

Follow up for #3297 changing apollo integrations.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 305c217

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.66 ms 444.69 ms 77.03 ms
Size 1.70 MiB 2.28 MiB 592.27 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/hsm-4-replacements-in-android-integrations to 8.x.x April 16, 2024 14:38
@adinauer adinauer merged commit 00c2535 into 8.x.x Apr 16, 2024
@adinauer adinauer deleted the feat/hsm-5-replacements-in-apollo-integrations branch April 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants