Hubs/Scopes Merge 2 - Replace IHub with IScopes in core
#3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
adinauer
changed the title
IHub with IScopes in coreIHub with IScopes in core
7 tasks
lbloder
reviewed
Apr 5, 2024
Collaborator
lbloder
left a comment
lbloder
left a comment
There was a problem hiding this comment.
Highlighted some leftover references to Hub on comments and messages.
Otherwise LGTM 👍
| super(hub, logger, flushTimeoutMillis, maxQueueSize); | ||
| this.hub = Objects.requireNonNull(hub, "Hub is required."); | ||
| super(scopes, logger, flushTimeoutMillis, maxQueueSize); | ||
| this.scopes = Objects.requireNonNull(scopes, "Hub is required."); |
Collaborator
There was a problem hiding this comment.
Message should refer to Scopes rather than Hub
sentry/src/main/java/io/sentry/SendCachedEnvelopeFireAndForgetIntegration.java
Show resolved
Hide resolved
| final @NotNull IHub hub, final @NotNull SentryOptions options) { | ||
| Objects.requireNonNull(hub, "Hub is required"); | ||
| final @NotNull IScopes scopes, final @NotNull SentryOptions options) { | ||
| Objects.requireNonNull(scopes, "Hub is required"); |
Collaborator
There was a problem hiding this comment.
Message should refer to Scopes rather than Hub
| registered = true; | ||
|
|
||
| this.hub = Objects.requireNonNull(hub, "Hub is required"); | ||
| this.scopes = Objects.requireNonNull(scopes, "Hub is required"); |
Collaborator
There was a problem hiding this comment.
Message should refer to Scopes rather than Hub
markushi
reviewed
Apr 12, 2024
markushi
reviewed
Apr 12, 2024
markushi
approved these changes
Apr 12, 2024
| private val dsnTest = "https://[email protected]/proj" | ||
|
|
||
| private fun generateHub(optionsConfiguration: Sentry.OptionsConfiguration<SentryOptions>? = null): IHub { | ||
| private fun generateHub(optionsConfiguration: Sentry.OptionsConfiguration<SentryOptions>? = null): IScopes { |
Member
There was a problem hiding this comment.
let's rename it to generateScopes?
Member
Author
There was a problem hiding this comment.
We need to create ScopesTest as a replacement for HubTest and thus don't need to change "hub" in HubTest as it's going to be removed anyways. Same should be true for Hub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Follow up for #3297 changing core.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps