Skip to content

Conversation

@markushi
Copy link
Member

@markushi markushi commented Mar 8, 2024

📜 Description

#skip-changelog

Example data can be seen on the ddm dashboard here.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4e54fbb

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 392.16 ms 440.22 ms 48.06 ms
Size 1.70 MiB 2.28 MiB 592.00 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea3 332.47 ms 401.12 ms 68.66 ms
86f0096 381.33 ms 476.58 ms 95.25 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
b172d4e 352.92 ms 446.50 ms 93.58 ms
d007225 365.63 ms 438.24 ms 72.62 ms
93a76ca 381.08 ms 459.22 ms 78.14 ms
7ab32b6 373.62 ms 480.61 ms 106.99 ms
d6d2b2e 392.55 ms 467.50 ms 74.95 ms
baaf637 418.39 ms 496.86 ms 78.47 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms

App size

Revision Plain With Sentry Diff
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
d007225 1.70 MiB 2.27 MiB 586.31 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
7ab32b6 1.70 MiB 2.27 MiB 584.63 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB

Previous results on branch: feat/spring-boot-metrics-example

Startup times

Revision Plain With Sentry Diff
7ea7355 304.83 ms 412.96 ms 108.13 ms
4ada312 330.06 ms 370.27 ms 40.21 ms
325853b 363.60 ms 426.00 ms 62.40 ms
6391e46 410.40 ms 500.69 ms 90.30 ms

App size

Revision Plain With Sentry Diff
7ea7355 1.70 MiB 2.28 MiB 592.01 KiB
4ada312 1.70 MiB 2.28 MiB 592.01 KiB
325853b 1.70 MiB 2.28 MiB 592.01 KiB
6391e46 1.70 MiB 2.28 MiB 592.01 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that formatting tho 🤮

@adinauer
Copy link
Member

adinauer commented Mar 8, 2024

Ah, should we add it to Spring Boot 2 (non jakarta) sample as well? And webflux samples too?

@markushi
Copy link
Member Author

markushi commented Mar 8, 2024

Ah, should we add it to Spring Boot 2 (non jakarta) sample as well? And webflux samples too?

👍 I also added spotlight to all of them

@markushi markushi enabled auto-merge (squash) March 8, 2024 13:18
@markushi markushi merged commit f5e1b97 into main Mar 8, 2024
@markushi markushi deleted the feat/spring-boot-metrics-example branch March 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants