-
-
Notifications
You must be signed in to change notification settings - Fork 461
Fix Ui tests receiving empty requests #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8838e01 | 387.41 ms | 467.00 ms | 79.59 ms |
| 4e260b3 | 384.08 ms | 477.56 ms | 93.48 ms |
| 93a76ca | 377.41 ms | 448.22 ms | 70.81 ms |
| 0bd723b | 375.20 ms | 452.41 ms | 77.20 ms |
| 86f0096 | 368.63 ms | 446.92 ms | 78.29 ms |
| 0404ea3 | 332.47 ms | 401.12 ms | 68.66 ms |
| b172d4e | 412.60 ms | 492.68 ms | 80.08 ms |
| 93a76ca | 397.30 ms | 455.16 ms | 57.87 ms |
| 8ff8fd0 | 432.77 ms | 495.18 ms | 62.41 ms |
| 7eccfdb | 389.94 ms | 461.29 ms | 71.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8838e01 | 1.72 MiB | 2.29 MiB | 578.15 KiB |
| 4e260b3 | 1.72 MiB | 2.27 MiB | 554.95 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| 0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
| 86f0096 | 1.72 MiB | 2.29 MiB | 576.50 KiB |
| 0404ea3 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
| b172d4e | 1.72 MiB | 2.29 MiB | 578.09 KiB |
| 93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
| 8ff8fd0 | 1.72 MiB | 2.27 MiB | 558.15 KiB |
| 7eccfdb | 1.72 MiB | 2.27 MiB | 556.93 KiB |
|
@stefanosiano it looks like the requests are actually not empty-bodied, but they look super weird, cause they are not errors or transactions really https://github.com/getsentry/sentry-java/actions/runs/7219916222/job/19671823552#step:8:411 |
…n't have such) added a check to discard already received envelopes, sent twice for any reason)
That should be the captured message event, just truncated in that log |
romtsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
📜 Description
added a check to avoid processing requests with 0 bytes bodies in ui tests (probably useless)
added a check to drop duplicated envelopes
#skip-changelog
💡 Motivation and Context
Some envelopes were sent twice, corrupting the counter in
MockRelayand making tests fail💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps