Actual mavenized build + stacktrace information #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kencochrane
added a commit
that referenced
this pull request
Feb 12, 2012
Actual mavenized build + stacktrace information, example app clean up, and added more docs.
|
These changes look good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added stacktrace information to the message for Sentry.
The previous pull request actually didn't turn it into a decent build for Maven, which I've now rectified. I also turned the example project into a "test case" for the project and updated the README to reflect these changes.
One last change: I fixed the date formatting of the timestamp in RavenUtils by using Apache Common's DateFormatUtils for thread-safe date formatting.