-
-
Notifications
You must be signed in to change notification settings - Fork 458
Allow filtering graphql errors #2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(m) Should we add an usage example to the spring-boot samples? i.e. just add a list of ignored error types to the properties file
Good Job 👍
sentry-graphql/src/main/java/io/sentry/graphql/SentryInstrumentation.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Configuration(proxyBeanMethods = false) | ||
| @Import(SentryGraphqlConfiguration.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the SentryGraphqlConfiguration class be deleted, or is it still of use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason why we didn't update the SentryGraphqlConfiguration class directly?
What does it change for someone manually using the SentryGraphqlConfiguration?
genuinely asking as i'm not so much into backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept sentry-spring/SentryGraphqlConfiguration for people using Spring (not Boot) and I wasn't able to update because SentryProperties lives in sentry-spring-boot so I decided to simply duplicate the config and use the one in sentry-spring-boot for auto config of Spring Boot. LMK if you can think of a simpler way to achieve what we want.
📜 Description
Allow users to privde a
List<String>to filter out certain GraphQL errors. Decided to useStringinstead of a specific type asStringcan easily be set in config files.💡 Motivation and Context
Closes #2899
💚 How did you test it?
Manually + unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps