-
-
Notifications
You must be signed in to change notification settings - Fork 461
add property to disable AOP related features that break graalvm build #2915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf202b | 364.28 ms | 419.66 ms | 55.38 ms |
| 9246ed4 | 281.79 ms | 352.08 ms | 70.29 ms |
| 3baa73f | 267.45 ms | 388.30 ms | 120.85 ms |
| 496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
| 9e60fc1 | 310.00 ms | 364.42 ms | 54.42 ms |
| 549cbb4 | 332.89 ms | 384.44 ms | 51.55 ms |
| 8820c5c | 330.60 ms | 416.86 ms | 86.26 ms |
| 4bf202b | 331.20 ms | 345.24 ms | 14.04 ms |
| fb296f0 | 340.61 ms | 394.88 ms | 54.27 ms |
| 0f34a0c | 321.75 ms | 377.68 ms | 55.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4bf202b | 1.72 MiB | 2.29 MiB | 575.54 KiB |
| 9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
| 3baa73f | 1.72 MiB | 2.29 MiB | 575.52 KiB |
| 496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
| 9e60fc1 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
| 549cbb4 | 1.72 MiB | 2.29 MiB | 575.74 KiB |
| 8820c5c | 1.72 MiB | 2.28 MiB | 571.82 KiB |
| 4bf202b | 1.72 MiB | 2.29 MiB | 575.54 KiB |
| fb296f0 | 1.72 MiB | 2.29 MiB | 575.70 KiB |
| 0f34a0c | 1.72 MiB | 2.29 MiB | 575.74 KiB |
Previous results on branch: feat/property_disable_aop
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cf9e84 | 327.80 ms | 371.94 ms | 44.14 ms |
| 4e473d2 | 310.57 ms | 362.45 ms | 51.88 ms |
| cd111b7 | 370.80 ms | 423.86 ms | 53.06 ms |
| 770bd4a | 309.08 ms | 352.71 ms | 43.63 ms |
| bb068c1 | 333.53 ms | 381.47 ms | 47.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1cf9e84 | 1.72 MiB | 2.29 MiB | 575.94 KiB |
| 4e473d2 | 1.72 MiB | 2.29 MiB | 575.91 KiB |
| cd111b7 | 1.72 MiB | 2.29 MiB | 575.90 KiB |
| 770bd4a | 1.72 MiB | 2.29 MiB | 575.94 KiB |
| bb068c1 | 1.72 MiB | 2.29 MiB | 575.94 KiB |
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
adinauer
approved these changes
Sep 6, 2023
Member
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just lacks a comment in SentryProperties to explain the flag.
sentry-spring-boot-jakarta/src/main/java/io/sentry/spring/boot/jakarta/SentryProperties.java
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add property
sentry.enable-aot-compatibilityto disable AOP, which breaks GraalVM Builds.💡 Motivation and Context
Currently it's not possible to build for GraalVM with performance enabled due to AOP on
@SentryTransactionand@SentrySpan. With this change performance can be enabled, but the AOP functionality is turned off.Fixes #2742
💚 How did you test it?
Add
id("org.graalvm.buildtools.native") version "0.9.24"plugin tobuild.gradleand run thebootBuildImagecommand.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps