Skip to content

Conversation

@maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Feb 11, 2022

📜 Description

Fix potential memory leaks - happening either when Sentry works in servlet environment on application undeployment - or when more than one integration is active.

💚 How did you test it?

Running a sample application. I am not sure if there is a way to write a test for that.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review February 11, 2022 22:50
@codecov-commenter
Copy link

Codecov Report

Merging #1909 (aa35889) into main (33bdce3) will increase coverage by 0.03%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1909      +/-   ##
============================================
+ Coverage     75.42%   75.46%   +0.03%     
- Complexity     2244     2248       +4     
============================================
  Files           225      225              
  Lines          8026     8037      +11     
  Branches        852      852              
============================================
+ Hits           6054     6065      +11     
  Misses         1562     1562              
  Partials        410      410              
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/MainEventProcessor.java 82.40% <0.00%> (ø)
.../io/sentry/spring/SentryInitBeanPostProcessor.java 97.67% <100.00%> (+0.45%) ⬆️
sentry/src/main/java/io/sentry/HostnameCache.java 90.69% <100.00%> (+0.69%) ⬆️
sentry/src/main/java/io/sentry/Sentry.java 42.28% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33bdce3...aa35889. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 651fa3d into main Feb 14, 2022
@maciejwalkowiak maciejwalkowiak deleted the avoid-memory-leaks branch February 14, 2022 12:00
kamilogorek pushed a commit that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants