-
-
Notifications
You must be signed in to change notification settings - Fork 461
Description
Problem Statement
Currently, SentryWebfluxAutoConfiguration registers the legacy filter (SentryWebfluxFilterConfiguration) whenever the property sentry.reactive.thread-local-accessor-enabled is not set. As a result, users who omit that property miss out on the benefits of the newer ThreadLocalAccessor-based filter.
Changing the default to SentryWebfluxFilterThreadLocalAccessorConfiguration would allow more users to benefit from improved context propagation without extra configuration.
Solution Brainstorm
Sentry 8.0.0 release candidate is in progress, so this is a good time to adjust the default behavior.
I propose:
- Add
matchIfMissing = trueto the@ConditionalOnPropertyinSentryThreadLocalAccessorCondition. - Remove
matchIfMissing = truefromSentryDisableThreadLocalAccessorCondition.
This way, SentryWebfluxFilterThreadLocalAccessorConfiguration is used when sentry.reactive.thread-local-accessor-enabled is not explicitly defined.
Users who still prefer the legacy filter can explicitly set sentry.reactive.thread-local-accessor-enabled=false.
Metadata
Metadata
Assignees
Labels
Projects
Status
Status