ref: Remove disabled_in_editor option from SentrySDK
#277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Remove `disabled_in_editor` option in favor of disabling sdk in the Godot editor by default.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Invalid Setting Reference Causes Restart Issue
The _requires_restart("sentry/options/disabled_in_editor") call attempts to set a restart requirement for a project setting that no longer exists, as its definition was removed. This call should either be removed or updated to reference an existing setting, such as sentry/options/disabled_in_editor_play if applicable.
src/sentry/sentry_options.cpp#L61-L62
sentry-godot/src/sentry/sentry_options.cpp
Lines 61 to 62 in be91e63
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jpnurmi
approved these changes
Jul 28, 2025
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove
disabled_in_editoroption in favor of disabling SDK in the Godot editor by default.