Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Apr 8, 2024

Bumps the @sentry/nextjs SDK to the v8 alpha. It may produce a lot of garbage performance data because we haven't built elaborate filtering logic yet.

@vercel
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 3:51pm

@codecov
Copy link

codecov bot commented Apr 8, 2024

Bundle Report

Changes will increase total bundle size by 826.46kB ⬆️

Bundle name Size Change
sentry-docs-server 7.17MB 1.05MB ⬆️
sentry-docs-edge-server 442.15kB 184.54kB ⬇️
sentry-docs-client 5.51MB 36.39kB ⬇️

Comment on lines -30 to -32
other: {
'sentry-trace': `${Sentry.getActiveSpan()?.toTraceparent()}`,
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add these back we need getsentry/sentry-javascript#11474 to land.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally don't like that we have this because it is bad dogfooding. Our users don't have this either.

@lforst lforst marked this pull request as ready for review April 8, 2024 15:14
@lforst lforst requested a review from HazAT April 8, 2024 15:14
HazAT
HazAT previously requested changes Apr 8, 2024
Luca Forstner and others added 2 commits April 8, 2024 17:17
Co-authored-by: Daniel Griesser <[email protected]>
Co-authored-by: Daniel Griesser <[email protected]>
@lforst lforst requested a review from HazAT April 8, 2024 15:17
@lforst lforst merged commit ba5dac1 into master Apr 9, 2024
@lforst lforst deleted the lforst-bump-sdk-to-v8-alpha branch April 9, 2024 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants