feat(js/replay): Opt-in options for unmask and unblock #9422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mydea
reviewed
Mar 12, 2024
| }); | ||
| ``` | ||
|
|
||
| Since v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then we recommend you to explicitly specify them in your configuration: |
Member
There was a problem hiding this comment.
Suggested change
| Since v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then we recommend you to explicitly specify them in your configuration: | |
| Starting with v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then we recommend you to explicitly specify them in your configuration: |
maybe fits better?
vivianyentran
approved these changes
Mar 12, 2024
Contributor
vivianyentran
left a comment
vivianyentran
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding!
| }); | ||
| ``` | ||
|
|
||
| Starting with v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then we recommend you to explicitly specify them in your configuration: |
Contributor
There was a problem hiding this comment.
Suggested change
| Starting with v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then we recommend you to explicitly specify them in your configuration: | |
| Starting with v8, the options `unblock` and `unmask` do not add default DOM selectors anymore. If you want to keep the default behavior of previous versions, then you should explicitly specify them in your configuration: |
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Mar 13, 2024
closes #8887 docs changes: getsentry/sentry-docs#9422
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-javascript#11049