Add wrapRemixHandleError instructions
#8681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
lizokm
approved these changes
Dec 13, 2023
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Made a few language tweaks, but otherwise this looks great!
Co-authored-by: Liza Mock <[email protected]>
|
I can file a bug for this, but using v7.91.0 of @sentry/remix generates: My import { init as SentryInit, wrapRemixHandleError } from '@sentry/remix'
import { renderHeadToString } from 'remix-island'
import { Head } from './root'
import { renderToReadableStream } from 'react-dom/server'
SentryInit({
dsn: 'https://6ea...',
tracesSampleRate: 0.1
})
export const handleError = wrapRemixHandleError |
|
I got it, the fix is to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: getsentry/sentry-javascript#9725
Updated
handleErrorinstructions to reflect the new feature.Also updated external links from Remix v1 documentation to v2.