update docs for vue 3 component tracking update #8547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snoozbuster is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Hey @Lms24 - could you double check this is all accurate? Also, we need to wait until the next release to merge this, yeah? |
src/platforms/javascript/guides/vue/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
shanamatthews
approved these changes
Nov 22, 2023
Contributor
shanamatthews
left a comment
shanamatthews
left a comment
There was a problem hiding this comment.
Looks good from the docs perspective!
Lms24
approved these changes
Nov 22, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Hey @snoozbuster thanks a lot for updating docs - appreciate your help! I agree we should show Vue 3 hooks more prominently. Makes sense to me.
@shanamatthews thanks for the ping! We can merge this anytime. The change was already released in 7.81.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Adds documentation for Vue 3 compatible performance tracing hooks added in getsentry/sentry-javascript#9578. Screenshot of changed section:
I chose to update the examples to be vue 3 first because vue 2 is reaching EOL at the end of the year - so it made sense to update the docs here to be Vue 3 first as that is already the default for most people right now (or at least, I would expect so).
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources