-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(feedback): product docs #8539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Co-authored-by: Ryan Albrecht <[email protected]>
vivianyentran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some suggestions but overall looks good!
Co-authored-by: vivianyentran <[email protected]>
vivianyentran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending the decision on naming
|
|
||
| ## Where to View User Feedback | ||
|
|
||
| Whether you choose to collect user feedback via a Feedback Widget, a Crash-Report modal, or both, you’ll be able to view it from the **User Feedback** page. The page is chronologically-organized with the most recent, unresolved feedback at the top. You can click on individual feedback to see more details all in one view, similar to your e-mail inbox. The right-hand side shows the **User Feedback Details** view, which includes the user’s description and any available debugging context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any differentiators between feedback from the form/widget and crash report in the UI? Or any way to filter for one or the other? If so, seems worthwhile to include that info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! There are differences indeed, lets expand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add to the bottom (after the last sentence in this heading:
Feedback collected via the Crash-Report Modal displays a crash-report label. And a link to the issue that resulted in the modal popping up.
Or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruno-garcia ^ I like this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I like that too!
Feedback collected via the Crash-Report Modal displays a crash-report label and a link to the issue that resulted in the modal popping up.
Would just make it one sentence instead of two.
But I'm not sure if I'm seeing the label correctly, as least in the demo app. It looks like this feedback has a linked issue but I don't see the label. Can you verify what it's supposed to look like?
https://demo.sentry.io/feedback/?feedbackSlug=android%3A4657517631&referrer=feedback_list_page&statsPeriod=7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's gone
|
Looks good to me! Only a couple other things to note:
|
Co-authored-by: Jasmin <[email protected]>
|
IMO we just need improved images and we should be ready to merge this. We can iterate from there with improvements, including link to SDK docs (instead of npm/github) once #8528 is merged |
|
@bruno-garcia Looks ready to ship! We'll need to follow up with a link to SDK docs here once they go live: "Learn more about how to install and customize it here." |
|
@jas-kas ready to merge anytime then. Holding it off until we have it open beta. Added to: https://github.com/getsentry/team-replay/issues/273 |
Co-authored-by: Michelle Zhang <[email protected]>
Links to Widget and Crash Report (old Modal) are temporary until SDK docs move around.
Moved User Feedback up the menu to be below Session Replay.
Screenshots taken as-is from draft docs, @Jesse-Box @jas-kas are these good enough? If not could u give a hand on getting better ones?
Relates to: #8493