Skip to content

Conversation

@lbloder
Copy link
Collaborator

@lbloder lbloder commented Aug 16, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Documents changes done in getsentry/sentry-java#2840

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

@vercel
Copy link

vercel bot commented Aug 16, 2023

@lbloder is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@lbloder lbloder marked this pull request as ready for review August 16, 2023 20:26
@lbloder lbloder requested a review from a team as a code owner August 16, 2023 20:26
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 10:18pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!


### Disable Sentry

To disable Sentry in the debug mode, use the `enabled` option:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To disable Sentry in the debug mode, use the `enabled` option:
To disable Sentry in debug mode, use the `enabled` option:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing. Found a technical issue with that sentence and fixed it.

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adinauer adinauer merged commit 91d4466 into getsentry:master Aug 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2023
@lbloder lbloder deleted the feat/disable-sentry-with-options branch February 6, 2024 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants