Laravel Cron Upserts #7279
Merged
Laravel Cron Upserts #7279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cleptric
force-pushed
the
laravel-upserts
branch
from
7c42c56 to
eb11b59
Compare
cleptric
force-pushed
the
laravel-upserts
branch
from
eb11b59 to
4e4d7ce
Compare
shanamatthews
approved these changes
Jun 27, 2023
Comment on lines
+33
to
+34
| // In case you want to configure the job monitor exclusively in the UI, you can turn off sending the monitor config with the check-in. | ||
| // Passing a monitor-slug is required in this case. |
There was a problem hiding this comment.
Suggested change
| // In case you want to configure the job monitor exclusively in the UI, you can turn off sending the monitor config with the check-in. | |
| // Passing a monitor-slug is required in this case. | |
| // If you want to configure the job monitor exclusively in the UI, you can turn off sending the monitor config with the check-in. | |
| // Passing a monitorSlug is required in this case. |
There was a problem hiding this comment.
Reading this page, this comment didn't make sense to me - what does it mean to "turn off sending the monitor config with the check-in"?
Just wanted to flag in case it may be confusing to users too.
There was a problem hiding this comment.
By default, we sent a so-called monitor config along each check-in containing parameters such as the schedule and time zone. To allow users to opt out of this behaviour, we added $updateMonitorConfig.
Co-authored-by: Shana Matthews <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
getsentry/sentry-laravel#677 must be merged and released prior to merging this PR.