Skip to content

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jun 20, 2023

It looks like createHashRouter can be wrapped by wrapCreateBrowserRouter.

getsentry/sentry-javascript#8317 (comment)
getsentry/sentry-javascript#8362

@vercel
Copy link

vercel bot commented Jun 20, 2023

@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 10:57pm

@shanamatthews shanamatthews requested a review from AbhiPrasad June 20, 2023 22:49
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from my perspective, but tagging @AbhiPrasad for content review.

@shanamatthews shanamatthews merged commit 2008a78 into getsentry:master Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants