Skip to content

chore: Remove suggestion to use Bitcode #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2023
Merged

chore: Remove suggestion to use Bitcode #7211

merged 6 commits into from
Jun 26, 2023

Conversation

@brustolin
Copy link
Contributor

@brustolin brustolin commented Jun 19, 2023 •
edited
Loading

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Apple don't support Bitcode anymore, so we remove the suggestions to use Bitcode to extract symbols.

Related to #6756

@brustolin brustolin requested a review from a team as a code owner June 19, 2023 14:07
@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:01pm

bitsandfoxes
bitsandfoxes reviewed Jun 19, 2023
View reviewed changes
kahest
kahest reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this @brustolin!

src/platform-includes/debug-symbols-apple/_default.mdx

When using Fastlane's _upload_to_testflight_ action, it's recommended to pass the _skip_waiting_for_build_processing_ parameter to speed up the action.

## Bitcode {#dsym-with-bitcode}
Copy link
Contributor

@kahest kahest Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: I'm wondering if we should keep this section for now and clearly point out that this will only work for old submissions that were done using bitcode (maybe also link to https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations)

Copy link
Contributor Author

@brustolin brustolin Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Is not possible to retrieve the symbols from the appconnect anymore.

@brustolin brustolin changed the title chore: Remove Bitcode documentation chore: Remove suggestion to use Bitcode Jun 20, 2023
@brustolin
Copy link
Contributor Author

brustolin commented Jun 20, 2023

@bitsandfoxes

Since Im updating docs on bitcode i will update for Unity as well.
Please check if my changes make sense.

@kahest
Copy link
Contributor

kahest commented Jun 20, 2023

Thanks for doing this @brustolin 💯
There's two more places we can clean up:

  • sentry-docs/src/platform-includes/getting-started-install/react-native.mdx

    Line 42 in 480bb06

    When you use Xcode, you can hook directly into the build process to upload debug symbols and source maps. However, if you are using bitcode, you will need to disable the “Upload Debug Symbols to Sentry” build phase and then separately upload debug symbols from iTunes Connect to Sentry.

  • sentry-docs/src/platforms/unity/troubleshooting.mdx

    Line 42 in 480bb06

    Sentry relies on debug symbols and line mappings being uploaded to provide line number support. By default, Unity exports an Xcode project with `Bitcode` enabled. This feature is [deprecated in Xcode 14](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes) and disables the automatic symbol upload.

@brustolin
Copy link
Contributor Author

brustolin commented Jun 20, 2023 •
edited
Loading

There's two more places we can clean up:

Unity troubleshooting has already mentioned that bitcode is deprecated, so I did not want to remove it at this time. I suppose this could serve as an additional source of information for older projects experiencing issues due to bitcode

@kahest
Copy link
Contributor

kahest commented Jun 20, 2023

There's two more places we can clean up:

Unity troubleshooting already mention that bitcode is deprecated, so I did not want to remove it for now. I guess this would be another source of information for old projects that started to have problems because of bitcode.

I think we can/should keep the mention, but consider the wording

@bitsandfoxes is the statement By default, Unity exports an Xcode project with Bitcode enabled. This feature is [deprecated in Xcode 14](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes) and disables the automatic symbol upload. still correct? Any more information we can give to users?

shanamatthews
shanamatthews approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from docs side!

bitsandfoxes
bitsandfoxes approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Had to release a new version of the Unity SDK to make it up to date with our shiny new docs! 🎉

@brustolin brustolin merged commit 432e903 into master Jun 26, 2023
@brustolin brustolin deleted the chore/remove-bitcode branch June 26, 2023 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

+2 more reviewers

@kahest kahest kahest left review comments

@shanamatthews shanamatthews shanamatthews approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brustolin @kahest @shanamatthews @bitsandfoxes