feat(android): Add docs for new ANR implementation #6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
13 tasks
shanamatthews
approved these changes
May 18, 2023
Contributor
shanamatthews
left a comment
shanamatthews
left a comment
There was a problem hiding this comment.
On my first readthrough I was unsure about when each version of the implementation would be used, so I made some suggestions to make it more obvious to readers.
Feel free to decline or re-edit if I got anything incorrect here!
Co-authored-by: Shana Matthews <[email protected]>
Co-authored-by: Shana Matthews <[email protected]>
Co-authored-by: Shana Matthews <[email protected]>
Member
Author
|
thanks @shanamatthews all of the comments make sense, I addressed them 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Adds docs explaining differences between old and new ANR implementation.