Skip to content

feat(sdk): add kmp platform #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 16, 2023
Merged

feat(sdk): add kmp platform #6452

merged 11 commits into from
Mar 16, 2023

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Mar 10, 2023

Adds Kotlin Multiplatform as a new sdk platform to the docs.
Some things such as performance monitoring, beforeSend etc are not included since the SDK does not support it yet

@buenaflor buenaflor requested a review from marandaneto March 10, 2023 10:09
@vercel
Copy link

vercel bot commented Mar 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 11:04AM (UTC)

marandaneto
marandaneto reviewed Mar 10, 2023
View reviewed changes
marandaneto
marandaneto reviewed Mar 10, 2023
View reviewed changes
lizokm
lizokm reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've set up time for us to chat. I'm curious as to why you've decided on this folder structure. There are a lot of folders and sub folders, which we don't usually do. Having this much fragmented information is going to make this page difficult to maintain, so would love to hear your thinking :)

I don't want to do a full review until we've decided on the folder structure. Looking forward to meeting you!

@marandaneto
Copy link
Contributor

marandaneto commented Mar 14, 2023

@buenaflor Let's add a note that is visible under the main page https://sentry-docs-git-feat-kmp-platform.sentry.dev/platforms/kotlin-multiplatform/#overview-of-the-features
that this is still experimental, there's a specific include for that, search for "We recognize the irony" that you will find out the include file.

@buenaflor buenaflor mentioned this pull request Mar 15, 2023
Merged
@buenaflor buenaflor marked this pull request as ready for review March 15, 2023 15:21
lizokm
lizokm approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! Made some language tweaks, but overall it looks good.

@buenaflor buenaflor merged commit 42dad12 into master Mar 16, 2023
@buenaflor buenaflor deleted the feat/kmp-platform branch March 16, 2023 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@marandaneto marandaneto marandaneto left review comments

@lizokm lizokm lizokm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@buenaflor @marandaneto @lizokm