nit pick #6411
Merged
nit pick #6411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
approved these changes
Mar 3, 2023
mydea
reviewed
Mar 3, 2023
| Add the following to your SDK config. There are several privacy and sampling options available, all of which can be set using the `integrations` constructor. Learn more about configuring Session Replay by reading the [configuration docs](https://docs.sentry.io/platforms/javascript/guides/nextjs/session-replay/). | ||
| Add the following to your SDK config. Several privacy and sampling options are available, all of which can be set using the `integrations` constructor. Learn more about configuring Session Replay by reading the [configuration docs](https://docs.sentry.io/platforms/javascript/guides/nextjs/session-replay/). | ||
|
|
||
| Note: The Replay integration *must* be added to your *`sentry.client.config.js`* file. Adding it into `sentry.server.config.js` or `sentry.edge.config.js` will do nothing. |
Member
There was a problem hiding this comment.
I am actually not 100% sure, but maybe we better not word this as will do nothing but as will break your build? This sounds as if you could add it and it will just be ignored, but IMHO it should def. not be added.
Member
There was a problem hiding this comment.
To be clear, it should actually just be ignored, but maybe from a docs perspective it is safer to make it clear that people should really not be adding this there?
Contributor
Author
There was a problem hiding this comment.
fine with that too, can be more explicit. maybe could break your build event thought, to be clear, i love drama :)
Co-authored-by: Liza Mock <[email protected]>
mydea
approved these changes
Mar 22, 2023
AbhiPrasad
pushed a commit
that referenced
this pull request
Mar 30, 2023
* nit pick less text, more bold * Update src/wizard/javascript/replay-onboarding/nextjs/2.configure.md Co-authored-by: Liza Mock <[email protected]> --------- Co-authored-by: Liza Mock <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less text, more bold