replay: config restructure #5927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imatwawana
reviewed
Dec 8, 2022
Contributor
imatwawana
left a comment
imatwawana
left a comment
There was a problem hiding this comment.
I know this is still in draft, but I wanted to get some feedback in early.
src/platforms/javascript/common/session-replay/configuration.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/session-replay/configuration.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/session-replay/configuration.mdx
Outdated
Show resolved
Hide resolved
ryan953
reviewed
Dec 8, 2022
src/platforms/javascript/common/session-replay/configuration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <[email protected]>
bruno-garcia
commented
Dec 8, 2022
|
|
||
| <Include name="beta-note-session-replay.mdx" /> | ||
|
|
||
| Sentry's Replay product is geared toward developers. By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. |
Contributor
There was a problem hiding this comment.
What are we trying to say by "Sentry's Replay product is geared toward developers"? All of Sentry is developer-focused, so if that's all we mean, this doesn't need to be here. If there's something more specific we want to say about this feature, then we should say that.
Suggested change
| Sentry's Replay product is geared toward developers. By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. | |
| By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. |
bruno-garcia
commented
Dec 8, 2022
src/platform-includes/session-replay/setup-session-replay/javascript.mdx
Outdated
Show resolved
Hide resolved
ryan953
approved these changes
Dec 8, 2022
imatwawana
reviewed
Dec 9, 2022
Contributor
imatwawana
left a comment
imatwawana
left a comment
There was a problem hiding this comment.
I've added some feedback that should be implemented on another PR.
|
|
||
| <Include name="beta-note-session-replay.mdx" /> | ||
|
|
||
| Sentry's Replay product is geared toward developers. By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. |
Contributor
There was a problem hiding this comment.
What are we trying to say by "Sentry's Replay product is geared toward developers"? All of Sentry is developer-focused, so if that's all we mean, this doesn't need to be here. If there's something more specific we want to say about this feature, then we should say that.
Suggested change
| Sentry's Replay product is geared toward developers. By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. | |
| By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. |
|
|
||
| Sentry's Replay product is geared toward developers. By default, it'll mask all fields, so no personally identifiable information (PII) is collected, eliminating any concerns with General Data Protection Regulation (GDPR). Learn more on <PlatformLink to="/session-replay/privacy">Session Replay Privacy</PlatformLink>. | ||
|
|
||
| With [session replays](/product/session-replay/) you can get to the root cause of an error or latency issue faster by seeing all the technical details related to that issue in one visual replay on your web application. Sentry provides a video-like reproduction of user interactions on a site or web app. All user interactions - including page visits, mouse movements, clicks, and scrolls - are captured, helping developers connect the dots between a known issue and how a user experienced it in the UI. |
Contributor
There was a problem hiding this comment.
Line 16 should really be the first paragraph on this page since this actually explains what the feature is.
| #### Configure | ||
|
|
||
| Add the following to your SDK config. There are several privacy and sampling options available, all of which can be set via the `integrations` constructor. Learn more about configuring Session Replay in our Github [Readme](https://github.com/getsentry/sentry-replay/blob/main/README.md). | ||
| Add the following to your SDK config. There are several privacy and sampling options available, all of which can be set via the `integrations` constructor. Learn more about configuring Session Replay by reading the [configuration docs](https://docs.sentry.io/platforms/javascript/session-replay/). |
Contributor
There was a problem hiding this comment.
On this and all these wizard files, the word "via" should be swapped for "using" since we avoid Latin words in the docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging, wizard needs to be updates (see: #5914) or redirects added.
A PR to change the snippet is pending review here (since the snippet is copied pasted in the wizard and docs/include: https://github.com/getsentry/sentry-docs/pull/5926/files#r1042813689
Once that review is done, wizard snippet updates will be pushed to this branch to fix the build.
See: #5903