Skip to content

Add support for PHP to beforeSendTransaction #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 6, 2022
Merged

Add support for PHP to beforeSendTransaction #5864

merged 5 commits into from
Dec 6, 2022

Conversation

@cleptric
Copy link
Member

@cleptric cleptric commented Nov 30, 2022 •
edited
Loading

No description provided.

@vercel
Copy link

vercel bot commented Nov 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 7:28PM (UTC)

@cleptric cleptric force-pushed the before-send-transaction branch from 6564e2c to c003c22 Compare November 30, 2022 11:13
@cleptric cleptric changed the title Add support for Java and PHP to beforeSendTransaction Add support for PHP to beforeSendTransaction Nov 30, 2022
@cleptric cleptric marked this pull request as draft November 30, 2022 11:13
@cleptric cleptric marked this pull request as ready for review November 30, 2022 12:02
@cleptric cleptric requested a review from a team November 30, 2022 12:02
@lobsterkatie
Copy link
Member

lobsterkatie commented Nov 30, 2022 •
edited
Loading

Man, I'm totally raining on your parade today, but can we separate the "adding PHP support" part of this from the "editing the filtering page" part? The latter is already addressed in #5804.

@cleptric cleptric force-pushed the before-send-transaction branch 2 times, most recently from 386c2d8 to 65c61a7 Compare November 30, 2022 19:00
@cleptric cleptric force-pushed the before-send-transaction branch from 65c61a7 to 9fb6eb7 Compare November 30, 2022 19:02
@cleptric
Copy link
Member Author

cleptric commented Nov 30, 2022

Yes we can

lobsterkatie
lobsterkatie approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the accuracy of the PHP code, but otherwise LGTM!

@cleptric cleptric removed the request for review from a team November 30, 2022 19:34
@cleptric cleptric self-assigned this Dec 6, 2022
@cleptric cleptric merged commit 892ec15 into master Dec 6, 2022
@cleptric cleptric deleted the before-send-transaction branch December 6, 2022 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees

@cleptric cleptric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cleptric @lobsterkatie