Skip to content

Conversation

@lobsterkatie
Copy link
Member

This removes the SDK Sample Rate section from the guide on transaction quota management, because sampleRate doesn't apply to transactions, and tracesSampleRate is covered by the next heading, SDK Tracing options.

@vercel
Copy link

vercel bot commented Nov 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Nov 21, 2022 at 10:55PM (UTC)

@imatwawana
Copy link
Contributor

So your edit for the Transactions quota mgmt page totally makes sense, but it affects this page as well. I'm not sure what the solution is. Maybe instead of Update SDK Sample Rate, two items called Update Error Sample Rate and Update Transaction Sample Rate?

@lobsterkatie lobsterkatie force-pushed the kmclb-remove-sampleRate-from-transaction-quota-guide branch from 270ac73 to 668f026 Compare November 21, 2022 22:40
@lobsterkatie
Copy link
Member Author

So your edit for the Transactions quota mgmt page totally makes sense, but it affects this page as well. I'm not sure what the solution is. Maybe instead of Update SDK Sample Rate, two items called Update Error Sample Rate and Update Transaction Sample Rate?

Good point. I'm surprised it didn't fail the link checker.

In any case, I think I fixed it. LMK what you think. (TL;DR, I mentioned sample rate in the section on tracing config, and changed the link to point there.)

@imatwawana
Copy link
Contributor

So your edit for the Transactions quota mgmt page totally makes sense, but it affects this page as well. I'm not sure what the solution is. Maybe instead of Update SDK Sample Rate, two items called Update Error Sample Rate and Update Transaction Sample Rate?

Good point. I'm surprised it didn't fail the link checker.

In any case, I think I fixed it. LMK what you think. (TL;DR, I mentioned sample rate in the section on tracing config, and changed the link to point there.)

Works for me! I suspect the link checker doesn't catch that because it can still resolve to a page even if it can't find the heading.

@lobsterkatie lobsterkatie merged commit 3d19f5d into master Nov 22, 2022
@lobsterkatie lobsterkatie deleted the kmclb-remove-sampleRate-from-transaction-quota-guide branch November 22, 2022 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants