Browser tracingOrigins is deprecated and replaced with tracePropagationTargets
#5759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timfish is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
9 tasks
AbhiPrasad
reviewed
Nov 10, 2022
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbhiPrasad
approved these changes
Nov 10, 2022
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/connect-services/javascript.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Abhijeet Prasad <[email protected]>
lizokm
reviewed
Nov 11, 2022
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Made some tweaks to the language.
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
tracingOriginswithtracePropagationTargets.I have not touched
tracingOriginsin relation to these because they will need to updated to the latest JavaScript SDK for these changes to become relevant:NetintegrationIt also updated the description for
shouldCreateSpanForRequestbecause it no longer considerstracingOrigins.