Skip to content

Update example to follow HMAC best practice #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Update example to follow HMAC best practice #5753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f38e44
Update example to follow HMAC best practice
mdtro Nov 9, 2022
d53fd28
Update webhooks.mdx
mdtro Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/docs/product/integrations/integration-platform/webhooks.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ import hashlib
import hmac
import json

expected_digest = request.headers['sentry-hook-signature']
expected_digest = request.headers.get('sentry-hook-signature') # returns None if header is missing
body = json.dumps(request.body)

digest = hmac.new(
Expand All @@ -74,8 +74,10 @@ digest = hmac.new(
digestmod=hashlib.sha256,
).hexdigest()

if not expected_digest: # The signature is missing
raise UnauthorizedError

if digest != expected_digest:
if not hmac.compare_digest(digest, expected_digest):
raise UnauthorizedError
```

Expand Down