Update python documentation for extras #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://github.com/getsentry/sentry-python/blob/master/tests/integrations/logging/test_logging.py#L46, extra data needs to be specified as a dict, passed as the keyword argument `extra`. If you follow the current documentation, you get an error; c.f. with the updated way: ``` >>> logging.error('test', extras=dict(foo='asdf')) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Users/Josh/.pyenv/versions/3.6.6/lib/python3.6/logging/__init__.py", line 1868, in error root.error(msg, *args, **kwargs) File "/Users/Josh/.pyenv/versions/3.6.6/lib/python3.6/logging/__init__.py", line 1336, in error self._log(ERROR, msg, args, **kwargs) TypeError: _log() got an unexpected keyword argument 'extras' >>> logging.error('test', extra=dict(foo='asdf')) ERROR:root:test ```
untitaker
approved these changes
Nov 13, 2018
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/getsentry/sentry-python/blob/master/tests/integrations/logging/test_logging.py#L46, extra data needs to be specified as a dict, passed as the keyword argument
extra.If you follow the current documentation, you get an error; c.f. with the updated way: