-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(apple): Add custom performance metrics #5629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only merge after releasing Cocoa 7.28.0. Related Cocoa PR getsentry/sentry-cocoa#2268.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
lizokm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, made a few formatting edits.
src/platform-includes/performance/automatic-performance-metrics/apple.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/custom-performance-metrics/apple.mdx
Outdated
Show resolved
Hide resolved
|
Hey Philipp, thanks for leaving this for us to review. @lizokm is our new docs manager! |
…pple.mdx Co-authored-by: lizokm <[email protected]>
…s/apple.mdx Co-authored-by: lizokm <[email protected]>
Only merge after releasing Cocoa 7.28.0. Related Cocoa PR getsentry/sentry-cocoa#2268.
This PR is similar to #5604.