Skip to content

feat(nextjs): Add transpileClientSDK option and build config page #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 28, 2022
Merged

feat(nextjs): Add transpileClientSDK option and build config page #5350

merged 4 commits into from
Jul 28, 2022

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jul 27, 2022 •
edited
Loading

In getsentry/sentry-javascript#5472, a transpileClientSDK option was added to the nextjs SDK to force SDK code to be transpiled along with other app code, primarily for the use of folks wanting to use the SDK in older browsers without support for ES6 or ES6+ features like object spread. This documents that option by:

  • Adding a section to the manual setup page (which is where other build-time options live)
  • Adding a new 'Build Options' page redirecting people to the relevant section of of the manual setup page, for greater discoverability
  • Adding a nextjs-specific include to a new legacy browser support section on the Troubleshooting page. (A generic include has also been added for the non-nextjs JS docs, detailing how to do manually what the added option causes the nextjs SDK to do automatically.)

@vercel
Copy link

vercel bot commented Jul 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 1:59PM (UTC)

@lobsterkatie lobsterkatie mentioned this pull request Jul 27, 2022
Merged
@lobsterkatie lobsterkatie mentioned this pull request Jul 27, 2022
Closed
5 tasks
AbhiPrasad
AbhiPrasad approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical stuff ✅

@lobsterkatie lobsterkatie force-pushed the kmclb-add-nextjs-transpileClientSDK-option branch 2 times, most recently from 26855e3 to 7d3cb25 Compare July 27, 2022 20:36
@lobsterkatie lobsterkatie force-pushed the kmclb-add-nextjs-transpileClientSDK-option branch from 7d3cb25 to 131d288 Compare July 27, 2022 21:02
imatwawana
imatwawana approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comma and posed a structural question, but otherwise LGTM!

@lobsterkatie @imatwawana
Add comma
996c0b8 
Co-authored-by: Isabel <[email protected]>
@lobsterkatie lobsterkatie enabled auto-merge (squash) July 28, 2022 13:42
@lobsterkatie lobsterkatie merged commit 9f89eae into master Jul 28, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-nextjs-transpileClientSDK-option branch July 28, 2022 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

+1 more reviewer

@imatwawana imatwawana imatwawana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lobsterkatie @AbhiPrasad @imatwawana