fix(python): Update snippet for setting transaction name #4818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/CeWSeygWiCGX4HVu4ikGUwu2dDjA |
sl0thentr0py
approved these changes
Mar 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons of backwards compatibility, we still support changing the active transaction's name by assigning to
scope.transaction, even thoughscope.transactionis actually theTransactionobject whose name you're changing. Eventually we won't support it, though, and in the meantime it's very confusing. This PR therefore updates the code to do it the right way, which is to first retrieve the transaction and then set its name directly.Fixes getsentry/sentry-python#1155.