-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Logging docs for Dart and Flutter #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/5oW2tUFumSnjpnMGmZQsxTCZMkcv |
|
cc @ueman |
ueman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments, this looks good to me 👍
Co-authored-by: Jonas Uekötter <[email protected]>
Co-authored-by: Jonas Uekötter <[email protected]>
| sentry: ^6.3.0 | ||
| sentry_logging: ^6.3.0 | ||
| logging: ^1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the package on release registry?
| sentry: ^6.3.0 | |
| sentry_logging: ^6.3.0 | |
| logging: ^1.0.2 | |
| sentry: ^{{ packages.version('sentry.dart') }} | |
| sentry_logging: ^{{ packages.version('sentry.dart.logging') }} | |
| logging: ^1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, that's why it's not using packages.version otherwise versions won't be aligned, I will fix that once I add it to the release registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imatwawana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor wording edits
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Closes #4472