Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 5, 2022

Closes #4472

@vercel
Copy link

vercel bot commented Mar 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/5oW2tUFumSnjpnMGmZQsxTCZMkcv
✅ Preview: https://sentry-docs-git-feat-logging-dart.sentry.dev

@marandaneto marandaneto requested a review from imatwawana March 5, 2022 15:45
@marandaneto
Copy link
Contributor Author

cc @ueman

Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, this looks good to me 👍

Comment on lines +18 to +20
sentry: ^6.3.0
sentry_logging: ^6.3.0
logging: ^1.0.2
Copy link
Member

@bruno-garcia bruno-garcia Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the package on release registry?

Suggested change
sentry: ^6.3.0
sentry_logging: ^6.3.0
logging: ^1.0.2
sentry: ^{{ packages.version('sentry.dart') }}
sentry_logging: ^{{ packages.version('sentry.dart.logging') }}
logging: ^1.0.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, that's why it's not using packages.version otherwise versions won't be aligned, I will fix that once I add it to the release registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording edits

@marandaneto marandaneto marked this pull request as ready for review March 7, 2022 14:19
@marandaneto marandaneto requested a review from a team as a code owner March 7, 2022 14:19
@marandaneto marandaneto merged commit 5a0a595 into master Mar 7, 2022
@marandaneto marandaneto deleted the feat/logging-dart branch March 7, 2022 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document Dart logging integration

5 participants