Skip to content

chore(web-vitals): organizing sections, updating thresholds and adding browser support #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2021
Merged

chore(web-vitals): organizing sections, updating thresholds and adding browser support #3814

merged 4 commits into from
Jun 30, 2021

Conversation

@doralchan
Copy link
Contributor

@doralchan doralchan commented Jun 29, 2021 •
edited
Loading

Before:
Screen Shot 2021-06-29 at 3 01 00 PM

After:
Screen Shot 2021-06-30 at 9 37 02 AM
Screen Shot 2021-06-30 at 9 36 48 AM

Note: FP and FCP should be 1.8s (updated Jan 21) but is currently 1s in the SDKs

@doralchan doralchan requested a review from a team as a code owner June 29, 2021 21:28
@vercel
Copy link

vercel bot commented Jun 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/8F1bCggJTHfavSxq2c5ZiGYcRwNY
✅ Preview: https://sentry-docs-git-chore-vitals-split-support.sentry.dev

@doralchan doralchan marked this pull request as draft June 29, 2021 21:28
@doralchan doralchan force-pushed the chore/vitals-split-support branch from 7660f0d to a35ef1d Compare June 30, 2021 16:31
@doralchan doralchan marked this pull request as ready for review June 30, 2021 16:37
@doralchan doralchan requested a review from imatwawana June 30, 2021 16:38
imatwawana
imatwawana approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imatwawana
Copy link
Contributor

imatwawana commented Jun 30, 2021

Apologies! I assumed this change was just the addition of the second table and didn't realize the page was completely restructured until I looked again. I'm not sure the flow of the page makes sense now. Shall comment again shortly.

imatwawana
imatwawana approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, all good! I mixed up the original and updated pages when reviewing. The new structure is a really big improvement. I made one small change to the original text, but otherwise this structural change looks great. Thank you!!

@doralchan doralchan merged commit 8043fef into master Jun 30, 2021
@doralchan doralchan deleted the chore/vitals-split-support branch June 30, 2021 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@imatwawana imatwawana imatwawana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doralchan @imatwawana