Skip to content

feat(node): Add docs for server side release health #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2021
Merged

feat(node): Add docs for server side release health #3541

merged 3 commits into from
May 17, 2021

Conversation

@ahmedetefy
Copy link
Contributor

@ahmedetefy ahmedetefy commented May 7, 2021 •
edited by HazAT
Loading

This PR:

  • Adds docs on how Release health in server-side (node) operates

@vercel
Copy link

vercel bot commented May 7, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/53ugdR8qESSsSmcncnGLfhiM6YNy
✅ Preview: https://sentry-docs-git-ahmed-release-health-node-docs.sentry.dev

@HazAT
Copy link
Member

HazAT commented May 7, 2021

We should be able to use node.jsx include as an import and have the separation there. So we don't need to write server-side, browser-side.

PeloWriter
PeloWriter suggested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may have duplicated information on the page (lines 5 and 36, lines 9 and 38). If so, we should have that content as a separate section that introduces what we capture, then cover client v. server side.

src/includes/configuration/auto-session-tracking/javascript.mdx
We create a session for every page load. For single-page applications, we will create a new session for every navigation change (History API).
### Browser-side

We create a session for every page load. For single-page applications, we will create a new session for every navigation change (History API).
Copy link
Contributor

@PeloWriter PeloWriter May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we link to the content for the History API.

src/includes/configuration/auto-session-tracking/javascript.mdx Outdated
We mark the session as an error if the SDK captures an event that contains an exception (this includes manually captured errors).
We mark the session as an error if the SDK captures an event that contains an exception (this includes manually captured errors).

By default, the JavaScript SDKs are sending sessions, to disable this toggle the flag `autoSessionTracking` to `false`:
Copy link
Contributor

@PeloWriter PeloWriter May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already stated on line 9?

src/includes/configuration/auto-session-tracking/javascript.mdx Outdated
We mark the session as crashed if an _unhandled error_ or _unhandled promise rejection_ bubbled up to the global handler.

We mark the session as an error if the SDK captures an event that contains an exception (this includes manually captured errors).
We mark the session as an error if the SDK captures an event that contains an exception (this includes manually captured errors).
Copy link
Contributor

@PeloWriter PeloWriter May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a duplicate of line 5?

@HazAT @PeloWriter @iker-barriocanal
Apply suggestions from code review
b7766ea 
Co-authored-by: Fiona <[email protected]>
Co-authored-by: iker barriocanal <[email protected]>
@HazAT HazAT mentioned this pull request May 11, 2021
Merged
@HazAT HazAT marked this pull request as ready for review May 17, 2021 07:43
@HazAT HazAT merged commit 3728064 into master May 17, 2021
@HazAT HazAT deleted the ahmed-release-health-node-docs branch May 17, 2021 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@rhcarvalho rhcarvalho rhcarvalho left review comments

@iker-barriocanal iker-barriocanal iker-barriocanal left review comments

@PeloWriter PeloWriter PeloWriter requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ahmedetefy @HazAT @rhcarvalho @iker-barriocanal @PeloWriter