Skip to content

Conversation

@imatwawana
Copy link
Contributor

Adding updated content for Org Stats page for EA

@imatwawana imatwawana requested a review from a team April 16, 2021 21:25
@vercel
Copy link

vercel bot commented Apr 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/8NXn5WQbF4AcWy9JaZYNnJPQfpEB
✅ Preview: https://sentry-docs-git-feature-add-org-stats-docs.sentry.dev

Copy link
Contributor

@manuzope manuzope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @imatwawana, think you meant to tag @getsentry/enterprise?


The page is designed for org admins, but is available to all team members. This is helpful if a team member who isn't an admin is tasked with reviewing these statistics. Also, this allows team members associated with specific projects to use this page to investigate why their events are being dropped.

[image here]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be an image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm just waiting on one, but just wanted to get this PR started in the meantime.

@manuzope manuzope requested a review from a team April 16, 2021 22:27
@PeloWriter
Copy link
Contributor

Great start. Holding on approval until images are loaded and the team finishes its review.

Copy link
Contributor Author

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited to move definitions into intro

Edited to move definitions of accepted, filtered, dropped into intro
Copy link
Member

@leedongwei leedongwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Holding off on an approval because (1) still need screenshots from me, and (2) we may rename "dropped" to "rate-limited".

@imatwawana
Copy link
Contributor Author

imatwawana commented Apr 26, 2021

Pushed some changes to the branch to address the EA note and change from "Dropped" to "Rate Limited". Also added a spot for the screenshot you're creating @leedongwei to be dropped in the src/docs/product/accounts/quotas/manage-event-stream-guide.mdx in addition to the new Org Stats page.

Adding time zone information; changing "time period" to "date range"
@imatwawana imatwawana merged commit 1e99cc6 into master Apr 27, 2021
@imatwawana imatwawana deleted the feature/add-org-stats-docs branch April 27, 2021 22:37
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop Org Stats documentation

5 participants