Skip to content

feat: Add performance docs for react #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2020
Merged

feat: Add performance docs for react #1792

merged 4 commits into from
Jun 30, 2020

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jun 25, 2020 •
edited
Loading

This PR adds performance docs for React. It walks through using the @sentry/react package and the Profiler to add React related spans to transactions.

image

@AbhiPrasad AbhiPrasad force-pushed the abhi/feat/react-profiler branch from 076a98b to b7a9a6c Compare June 26, 2020 12:38
@AbhiPrasad AbhiPrasad marked this pull request as ready for review June 29, 2020 13:10
@AbhiPrasad AbhiPrasad requested review from HazAT and MimiDumpling June 29, 2020 13:10
MimiDumpling
MimiDumpling reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested edits. 🌻 Thanks for helping with docs!

@AbhiPrasad @dashed @MimiDumpling
Apply suggestions from code review
09d2769 
Co-authored-by: Alberto Leal <[email protected]>
Co-authored-by: Tien "Mimi" Nguyen <[email protected]>
@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented Jun 30, 2020

Thank you for the review @MimiDumpling and @dashed. Here is what the page looks like now.

image

dashed
dashed approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

MimiDumpling
MimiDumpling approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Abhi!

@AbhiPrasad AbhiPrasad merged commit b01e0cd into master Jun 30, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/feat/react-profiler branch June 30, 2020 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dashed dashed dashed approved these changes

@HazAT HazAT Awaiting requested review from HazAT

+1 more reviewer

@MimiDumpling MimiDumpling MimiDumpling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbhiPrasad @dashed @MimiDumpling