Skip to content

docs: Vue tracing integration #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2020
Merged

docs: Vue tracing integration #1757

merged 4 commits into from
Jun 18, 2020

Conversation

@kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jun 16, 2020

AbhiPrasad
AbhiPrasad requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some changes for grammar. Feel free to reword my suggestions.

This is the first time I'm reading through the source code properly though, and it the integration is very cool. For sure a game changer (excited for that shipped email 👀)

AbhiPrasad
AbhiPrasad reviewed Jun 16, 2020
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing request changes to unblock, but will defer to docs for final approval. LGTM though!

MimiDumpling
MimiDumpling reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 Thanks for helping with docs, Kamil! After the suggested edits are applied, I might take another look to make sure I have the correct usage of "we" and "you" in this context. Thanks!

kamilogorek
kamilogorek commented Jun 17, 2020
View reviewed changes
kamilogorek
kamilogorek commented Jun 17, 2020
View reviewed changes
@kamilogorek @MimiDumpling
Apply suggestions from code review
c8e6718 
Co-authored-by: Tien "Mimi" Nguyen <[email protected]>
@kamilogorek
Copy link
Contributor Author

kamilogorek commented Jun 17, 2020

@MimiDumpling updated and left some comments

MimiDumpling
MimiDumpling approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@kamilogorek @MimiDumpling
Apply suggestions from code review
5564482 
Co-authored-by: Tien "Mimi" Nguyen <[email protected]>
@kamilogorek kamilogorek merged commit 941bae2 into master Jun 18, 2020
@kamilogorek kamilogorek deleted the vue-apm branch June 18, 2020 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@HazAT HazAT Awaiting requested review from HazAT

@PeloWriter PeloWriter Awaiting requested review from PeloWriter

+1 more reviewer

@MimiDumpling MimiDumpling MimiDumpling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilogorek @AbhiPrasad @MimiDumpling