added example code to React Native for setDist #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
May 8, 2020
| : This is the version code or build ID depending on your platform. So for instance just set this to whatever is set in your _Info.plist_ or what your Gradle setup generates (For example, `52`). | ||
|
|
||
| ```js | ||
| Sentry.setDist(`dist`); |
There was a problem hiding this comment.
We mention in the previous paragraph that an example is 52, should this match?
There was a problem hiding this comment.
The example directly above this section for setting releases uses: Sentry.setRelease(RELEASE_NAME)`
Should we match that and use
Sentry.setDist(DISTRIBUTION_NAME)
instead?
There was a problem hiding this comment.
O yeah @mbauer404 's suggestion makes more sense since you would never hardcode a 52
There was a problem hiding this comment.
Great suggestion, @mbauer404 ! Let me know if there are other changes we should address. If not, feel free to approve. ;)
mbauer404
approved these changes
May 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer wrote into Support about confusion over
setDist. This PR gives a code example of how to usesetDist.Before:
After:
