-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Add firebase docs integration #15310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.29kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
logaretm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
very L: should we add a version availability note? I don't see us doing that a lot around the docs anyways so feel free to ignore.
I thought about it but wanted to get the teams perspective on this, since this is a new pattern we would follow (at least I haven't seen it that yet in the docs). But overall I would highly vote for this |
sfanahata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview looks good.
0dda5a6 to
5304c6e
Compare
DESCRIBE YOUR PR
This adds the documentation for Firebase integrations added in getsentry/sentry-javascript#17952 and getsentry/sentry-javascript#16719
closes #15247
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES