Skip to content

Conversation

@limbonaut
Copy link
Collaborator

DESCRIBE YOUR PR

Document structured logging for the Godot SDK, added in:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 22, 2025 10:07pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 22, 2025 10:07pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 22, 2025 17:22
@codecov
Copy link

codecov bot commented Oct 22, 2025

Bundle Report

Changes will decrease total bundle size by 1.39MB (-5.92%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 11.59MB -1.39MB (-10.74%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/Sb66wiJ-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Sb66wiJ-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1M4JuMVns3N02TcTBATcU/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/1M4JuMVns3N02TcTBATcU/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -33.51kB 1.74MB -1.89%
../instrumentation.js -33.8kB 1.07MB -3.07%
9523.js -33.51kB 1.04MB -3.11%
../app/[[...path]]/page.js.nft.json -430.55kB 428.53kB -50.12%
../app/platform-redirect/page.js.nft.json -430.55kB 428.45kB -50.12%
../app/sitemap.xml/route.js.nft.json -430.55kB 425.68kB -50.28%
7153.js (New) 30.3kB 30.3kB 100.0% 🚀
../app/api/ip-ranges/route.js -300 bytes 5.79kB -4.92%
../app/robots.txt/route.js -300 bytes 5.02kB -5.64%
2311.js (Deleted) -30.9kB 0 bytes -100.0% 🗑️

App Routes Affected:

App Route Size Change Total Size Change (%)
/ -600 bytes 2.81MB -0.02%

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a little confusion about the alert on log attributes and string interpolation. Is that heads up about methods? Might benefit from a bit more specificity.

@limbonaut limbonaut merged commit 4b5cbc3 into master Oct 24, 2025
13 checks passed
@limbonaut limbonaut deleted the godot-structured-logs branch October 24, 2025 11:07
codyde added a commit that referenced this pull request Oct 27, 2025
…s-examples

* origin/master: (478 commits)
  docs(godot): Structured logging (#15287)
  fix(batch-processor): Don't enforce starting timer (#15309)
  feat(node): Add new options to nativeNodeFetchIntegration (#15282)
  Updated dotnet options to include all defaults (#15218)
  ref: add docs that logs channel is optional (#15172)
  docs(svelteKit): Update build-time options for source maps (#15283)
  fix(python): Fix paragraph order in Strawberry docs (#15301)
  Added docs explaining how to disable Sentry Native in the .NET SDK (#15293)
  Updated Unity options with missing defaults (#15219)
  docs(otlp): Update docs for client SDK w3c traceparent support (#15294)
  Adding defaults for Godot options (#15216)
  feat(crons): Document broken monitors feature (#15280)
  fix: Remove OTLP logs from EA list (#15288)
  Bump API schema to 06047b60 (#15276)
  ref(nextjs): Move manual instrumentation examples for ai into Edge section (#15284)
  docs(otlp): change status to open beta (#15285)
  Hono runtime and middleware doc updates (#14853)
  feat(logs): Clarify API for Hub/Scope and Client (#15281)
  docs(astro/nuxt): Remove `sourceMapsUploadOptions` option nesting (#14905)
  docs(profiling): Add docs for Profiling API (#15258)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants