feat: Update logs spec to mention message template constraint #14759
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
k-fish
reviewed
Aug 28, 2025
develop-docs/sdk/telemetry/logs.mdx
Outdated
| @@ -299,6 +299,8 @@ If the log was paramaterized the SDK should attach the following | |||
| } | |||
| ``` | |||
|
|
|||
| If there are no `sentry.message.parameter.X` attributes included in the log, then the SDK MUST NOT attach a `sentry.message.template` attribute. | |||
There was a problem hiding this comment.
Can you add that this is important for PII reasons, since lacking parameter means that template isn't a template but a clone of body?
k-fish
approved these changes
Aug 28, 2025
AbhiPrasad
commented
Aug 28, 2025
This was referenced Aug 28, 2025
This was referenced Aug 28, 2025
This was referenced Aug 28, 2025
codyde
added a commit
that referenced
this pull request
Aug 29, 2025
* 'master' of https://github.com/getsentry/sentry-docs: feat(seer): Seer webhook docs (#14702) feat: Update logs spec to mention message template constraint (#14759) Unreal Engine: Update sampling docs (#14740) Unreal Engine: Update info about reading certain options from env vars (#14714) feat(Apple): Add `enableUnhandledCPPExceptionsV2` to experimental features (#14731) feat(kmp): Add Sentry Cocoa compatibility version info (#14737) Fix reference to span in processOrderBatch function (#14741) chore(java): Add docs on how to use tracePropagationTargets (#14752)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.