-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix(dotnet) Add Null safety to doc #14637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Seer failed to run. |
Bundle ReportChanges will increase total bundle size by 549 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
App Routes Affected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer pattern matching over operator, which can be overloaded
platform-includes/distributed-tracing/custom-instrumentation/dotnet.mdx
Outdated
Show resolved
Hide resolved
platform-includes/distributed-tracing/custom-instrumentation/dotnet.mdx
Outdated
Show resolved
Hide resolved
Thanks for fixing this |
…otnet.mdx Co-authored-by: Bruno Garcia <[email protected]>
…otnet.mdx Co-authored-by: Bruno Garcia <[email protected]>
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Fix
Value cannot be null. (Parameter 'bytes')
when users copy/paste this code into their servers.This happens because on the same doc, those values can be null
So we add some null checks before retrieving the trace or baggage and everyone gets happy!.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES