Skip to content

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Aug 12, 2025

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Fix Value cannot be null. (Parameter 'bytes') when users copy/paste this code into their servers.

This happens because on the same doc, those values can be null

properties.Headers.Add("sentry-trace", SentrySdk.GetTraceHeader()?.ToString());
properties.Headers.Add("baggage", SentrySdk.GetBaggage()?.ToString());

So we add some null checks before retrieving the trace or baggage and everyone gets happy!.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Preview Comment Aug 14, 2025 10:20am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored Preview Aug 14, 2025 10:20am

Copy link
Contributor

Seer failed to run.

Copy link

codecov bot commented Aug 12, 2025

Bundle Report

Changes will increase total bundle size by 549 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB 81 bytes (0.0%) ⬆️
sentry-docs-server-cjs 12.44MB 468 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/8423-*.js 87 bytes 285.0kB 0.03%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/H1NJ_ZBtl_UdvIv9hSO7c/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/H1NJ_ZBtl_UdvIv9hSO7c/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XaehLPVlrkk5IRyldlYgr/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/XaehLPVlrkk5IRyldlYgr/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 130 bytes 749.24kB 0.02%
../app/platform-redirect/page.js.nft.json 130 bytes 749.15kB 0.02%
../app/sitemap.xml/route.js.nft.json 130 bytes 746.62kB 0.02%
../app/[[...path]]/page.js 87 bytes 607.99kB 0.01%

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 87 bytes 3.17MB 0.0%

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer pattern matching over operator, which can be overloaded

@bruno-garcia bruno-garcia requested a review from Flash0ver August 13, 2025 13:30
@bruno-garcia
Copy link
Member

Thanks for fixing this

@bruno-garcia bruno-garcia merged commit fbd5983 into master Aug 19, 2025
12 of 13 checks passed
@bruno-garcia bruno-garcia deleted the lz/dotnet/fix/rabbitmq-doc branch August 19, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants