Skip to content

fix(profiling): fix sample v2 timestamp doc #14165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Jun 26, 2025

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2025 1:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Jun 26, 2025 1:44pm

@@ -199,8 +199,7 @@ milliseconds.
: *List, required* Contains a list of sample object captured during execution.
Each sample can contain the following attributes:

- `timestamp`: *64-bit floating point, required.* Contains the Unix timestamp in seconds with microseconds precision.
in seconds with millisecond precision when the sample was captured.
- `timestamp`: *64-bit floating point, required.* Contains the Unix timestamp in seconds with microseconds precision when the sample was captured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `timestamp`: *64-bit floating point, required.* Contains the Unix timestamp in seconds with microseconds precision when the sample was captured.
- `timestamp`: *64-bit floating point, required.* Contains the Unix timestamp in seconds with microseconds precision of when the sample was captured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants