Skip to content

Conversation

@kahest
Copy link
Contributor

@kahest kahest commented Apr 22, 2025

DESCRIBE YOUR PR

Adds explanation on how users are identified on Mobile, and for which purpose.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 3:31pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:31pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:31pm

@kahest kahest changed the title adds note about how user ids are handled chore(legal): Add note about how users are identified on Mobile Apr 22, 2025
@kahest kahest requested a review from bruno-garcia April 22, 2025 10:07
@codecov
Copy link

codecov bot commented Apr 22, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/zuyZVl4Fjf8GYc8P7-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/zuyZVl4Fjf8GYc8P7-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/RsVbnx-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/RsVbnx-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a different approach that's more verbose but tries to go in more details on why it's not perfect, but close enough.

But feel free to go with the original framing if you prefer.

@kahest kahest marked this pull request as ready for review April 24, 2025 09:12
@kahest kahest merged commit 33b075e into master Apr 24, 2025
15 checks passed
@kahest kahest deleted the kahest/mobile-privacy-ids branch April 24, 2025 09:16
bitsandfoxes pushed a commit that referenced this pull request Apr 24, 2025
Adds explanation on how users are identified on Mobile, and for which
purpose.

---------

Co-authored-by: Bruno Garcia <[email protected]>
codyde added a commit that referenced this pull request Apr 26, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (49 commits)
  Bump API schema to f203c35d (#13523)
  Update index.mdx (#13345)
  feat(toggle): Adding docs for the toggle command (#13487)
  feat(Unity): Added `trace ID` connecting error explainer  (#13516)
  feat(Unity): Editor Facelift (#13514)
  feat(Unity): Updated `options` and error capture explainer (#12904)
  Add data collected page for KMP (#13485)
  adjust language to be clear on developer privacy responsability (#13502)
  Factory and Teamcamp integrations (#13365)
  feat: More clearly document log envelope item in logs spec (#13501)
  Small improvements to `traces_sampler` configuration.  (#13470)
  docs(js): Further clarify `denyUrls` (#13481)
  fix(js): Update `denyUrls` text in filtering page (#13494)
  docs(js): Fix uglify example command (#13329)
  chore(legal): Add note about how users are identified on Mobile (#13465)
  feat(native): add data collected page (#13483)
  ref(sourcemaps): Add faulty community-maintained packages to troubleshooting doc (#12915)
  feat(changelog): Add missing form-textarea class to editor (#12893)
  Remove 'Set Up' prefix from sidebar titles across all platforms (#13392)
  Bump API schema to 7028abc0 (#13490)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants