Skip to content

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 13, 2025

@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:05pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:05pm

@aliu39 aliu39 requested review from a team, cmanallen and sentrivana February 13, 2025 23:52
@codecov
Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Changes will increase total bundle size by 186 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB 192 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 67 bytes 377.58kB 0.02%
../app/platform-redirect/page.js.nft.json 67 bytes 377.5kB 0.02%
../app/sitemap.xml/route.js.nft.json 67 bytes 375.47kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/z5b5FSE1dpDFlox_M-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/z5b5FSE1dpDFlox_M-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/o0FsNnFEfXXB4wprotIN2/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/o0FsNnFEfXXB4wprotIN2/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! 🥔 LGTM, but please see comments and we should also add Statsig to the big integrations table in docs/platforms/python/integrations/index.mdx.

We will cut an SDK release with the integration likely sometime next week so I wouldn't merge this until then to not confuse folks -- we can leave it open and I can hit the merge button once the release is out.

@aliu39
Copy link
Member Author

aliu39 commented Feb 14, 2025

Sounds good, thank you @sentrivana !!

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link from the /integrations lists to the statsig integration is not working.

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links fixed and checked in preview!

@antonpirker antonpirker merged commit 049b5e8 into master Feb 17, 2025
11 checks passed
@antonpirker antonpirker deleted the aliu/statsig-python branch February 17, 2025 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants