Change redactAllText and redactAllImages to maskAllText and maskAllImages #12537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages This is based on the change in getsentry/sentry-java#3741 redactAllText and redactAllImages are no longer valid in XCode, and have been replaced with maskAllText and maskAllImages
|
@ademirev is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
@philipphofmann mind taking a look? |
philipphofmann
approved these changes
Feb 4, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Good catch thanks @ademirev 💯
Member
|
@coolguyzone, I can't authorize the required CI checks so we can merge the PR. Can you do that? |
coolguyzone
approved these changes
Feb 4, 2025
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
|
Thanks @philipphofmann , I will run the builds and merge 🏄♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the change in getsentry/sentry-java#3741
DESCRIBE YOUR PR
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.