Skip to content

Conversation

@LancelotP
Copy link
Contributor

DESCRIBE YOUR PR

While following the documentation over at https://docs.sentry.io/platforms/javascript/guides/remix/manual-setup I founded that the method wrapRemixHandleError is marked as deprecated.

Digging through the issues I found getsentry/sentry-javascript#10370. This PR fix the reference to the new method.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.)
  • Other deadline
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

The old method wrapRemixHandleError is marked as deprecated. Replace with the new one mentioned in getsentry/sentry-javascript#10212
@vercel
Copy link

vercel bot commented Jun 13, 2024

@LancelotP is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vivianyentran vivianyentran requested a review from AbhiPrasad June 13, 2024 16:49
@vivianyentran
Copy link
Contributor

@AbhiPrasad can you help review?

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thank you!

@vercel
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ❌ Failed (Inspect) Jun 13, 2024 5:01pm

@AbhiPrasad AbhiPrasad merged commit 2a0dcb6 into getsentry:master Jun 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants