-
-
Notifications
You must be signed in to change notification settings - Fork 276
Fix wrong SDK being reported when sentry_logging is used #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong SDK being reported when sentry_logging is used #725
Conversation
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
- Coverage 92.30% 90.70% -1.61%
==========================================
Files 17 104 +87
Lines 520 3335 +2815
==========================================
+ Hits 480 3025 +2545
- Misses 40 310 +270
Continue to review full report at Codecov.
|
4392d4e to
7a2fc4a
Compare
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kuhnroyal
brustolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@kuhnroyal |
|
@marandaneto Seems unrelated: |
Thanks, |
📜 Description
Fixes #717
💡 Motivation and Context
💚 How did you test it?
I checked the Sentry UI, the package doesn't seem to be reported anywhere tho.
📝 Checklist
🔮 Next steps