Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

📜 Description

Fixes #717

💡 Motivation and Context

💚 How did you test it?

I checked the Sentry UI, the package doesn't seem to be reported anywhere tho.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #725 (8191569) into main (17894ef) will decrease coverage by 1.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   92.30%   90.70%   -1.61%     
==========================================
  Files          17      104      +87     
  Lines         520     3335    +2815     
==========================================
+ Hits          480     3025    +2545     
- Misses         40      310     +270     
Impacted Files Coverage Δ
logging/lib/src/logging_integration.dart 90.90% <100.00%> (-1.95%) ⬇️
dart/lib/src/sentry_envelope_item.dart 97.77% <0.00%> (ø)
dart/lib/src/protocol/sdk_version.dart 100.00% <0.00%> (ø)
dart/lib/src/transport/rate_limiter.dart 87.80% <0.00%> (ø)
dart/lib/src/protocol/sentry_request.dart 98.03% <0.00%> (ø)
dart/lib/src/protocol/debug_image.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/sentry_event.dart 100.00% <0.00%> (ø)
dart/lib/src/protocol/breadcrumb.dart 100.00% <0.00%> (ø)
dart/lib/src/sentry_client.dart 94.17% <0.00%> (ø)
dart/lib/src/sentry_sampling_context.dart 100.00% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17894ef...8191569. Read the comment docs.

@kuhnroyal kuhnroyal force-pushed the fix/sentry-logging-sdk-reporting branch from 4392d4e to 7a2fc4a Compare January 29, 2022 14:36
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kuhnroyal

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto
Copy link
Contributor

@kuhnroyal package-analysis counted -10 points using pana, mind checking it out?

@kuhnroyal
Copy link
Contributor Author

@marandaneto Seems unrelated:

### [~] 20/30 points: code has no errors, warnings, lints, or formatting issues\n\n<details>\n<summary>\nINFO: Prefer typing uninitialized variables and fields.\n</summary>\n\n`lib/src/sentry_exception_factory.dart:19:9`\n\n```\n   ╷\n19 │     var mechanism;\n   │         ^^^^^^^^^\n   ╵\n```\n\nTo reproduce make sure you are using the [lints_core](pub.dev/packages/lints) and run `dart analyze lib/src/sentry_exception_factory.dart`\n</details>

@marandaneto
Copy link
Contributor

sentry_exception_factory

Thanks, dart package still uses pedantic, but this one is related to the lints package.
Time to address #507 :D

@marandaneto marandaneto merged commit 28f2085 into getsentry:main Feb 1, 2022
@kuhnroyal kuhnroyal deleted the fix/sentry-logging-sdk-reporting branch March 2, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix sdk reporting of sentry_logging

4 participants